[Core, Rust Server] anyOf / oneOf support for Rust Server #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums need to be named types, so handle them as part of inline model resolution
etherealjoy
reviewed
Jun 24, 2020
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java
Outdated
Show resolved
Hide resolved
jimschubert
reviewed
Jan 10, 2021
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java
Outdated
Show resolved
Hide resolved
...es/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustServerCodegen.java
Outdated
Show resolved
Hide resolved
...es/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustServerCodegen.java
Outdated
Show resolved
Hide resolved
...es/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustServerCodegen.java
Outdated
Show resolved
Hide resolved
...es/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustServerCodegen.java
Outdated
Show resolved
Hide resolved
|
CircleCI passsed, but seems to have failed to sync with GitHub - https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/8310/workflows/54e31e58-6aab-45e7-83f9-4b41106f8790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds anyOf/oneOf support for the Rust Server generator using the support added in Metaswitch/swagger-rs#112
There's a couple of minor core changes to InlineModelResolver - @OpenAPITools/generator-core-team:
If we get a model named
12345AnyOfObject, rename it to_12345AnyOfObject, not_2345AnyOfObject.This means for Rust Server, it'll end up as Model12345AnyOfObject, instead of Model2345AnyOfObject, which is nonsensical.
Perform inline model resolution for enums, and pass the type through when performing inline model resolution.
There's a couple of minor fixups in Rust Server:
Some minor template tweaking, including putting the IntoHeader implementation below the model definition.
Update the supported features - we've support XML Structure Definition for a while - but the global feature flag is wrong - see user feedback in [REQ] [rust] Support XML objects in requests and responses #5594.
Handle FromStr properly, which breaks for the oneOf model otherwise.
Optimistically, I'd like to merge this before 5.0 gets cut.
This change is by @mirw and myself on behalf of @Metaswitch.
Rust Server Technical Committee
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master